Remove conversions from String<>ScSymbol/ScVal #329
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Remove conversions from String<>ScSymbol/ScVal.
Why
The conversions are not intuitive. ScVal also has a String variant, and so the fact that String types convert to ScSymbol/ScVal::Symbol can be surprising. Since we have multiple types that are clearly strings in some form, I think we should require explicit conversions in code that needs to convert.
If needed we can follow up with some help functions such as ScVal::symbol_from_str and ScVal::string_from_str.
Merging
Intended to be merged to main after: